Expose projection hints in parquet queryable #7152
Open
+646
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
expose-projection-hints
branch
from
05f8242 to
9c6dc46
Compare
Member
|
LGTM, can you check the lint CI? |
Contributor
Author
|
@SungJin1212 I am waiting for prometheus-community/parquet-common#128 to be merged first. The current projection hints implementation will fail for the default case where the query cannot use projection pushdown |
yeya24
force-pushed
the
expose-projection-hints
branch
3 times, most recently
from
5b2e6a0 to
e25a78e
Compare
Member
|
LGTM, can you add a changelog? |
yeya24
force-pushed
the
expose-projection-hints
branch
from
68d3a4d to
efd096d
Compare
Signed-off-by: yeya24 <benye@amazon.com>
yeya24
force-pushed
the
expose-projection-hints
branch
from
efd096d to
4552f4a
Compare
alanprot
reviewed
Dec 19, 2025
| sortSeries = true | ||
| } | ||
|
|
||
| queryIngesters := q.queryIngestersWithin == 0 || maxt >= util.TimeToMillis(time.Now().Add(-q.queryIngestersWithin).Add(-q.projectionHintsIngesterBuffer)) |
Member
There was a problem hiding this comment.
This maxt is the original maxt or is the maxt already changed to not contain the timestamp for data in the ingesters?
alanprot
reviewed
Dec 19, 2025
| blocksStoreQuerier storage.Querier | ||
|
|
||
| // If set, the querier manipulates the max time to not be greater than | ||
| // "now - queryStoreAfter" so that most recent blocks are not queried. |
Member
There was a problem hiding this comment.
this is what worried about.. that the maxT is already manipulated so we do not see that the query was going to ingesters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR supports projection pushdown in Parquet Queryable. New config is added to honor projection hints.
Projection pushdown is only enabled if:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]